Fix potential overflow #120357
Open
Fix potential overflow #120357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
|
I assume you've meant |
|
Yes, sorry, fixed it |
|
short MinValue is -32768. That does not make much sense to me either. I could see the arguments that the length should be positive. |
|
The change was originally intended to only make the overflow impossible. But enforcing the positive length is more logical, I will change it. |
This was referenced Oct 3, 2025
EgorBo
reviewed
Oct 3, 2025
| private static unsafe void SetField(ref MessageField field, int length, int offset) | ||
| { | ||
| if (length > short.MaxValue) | ||
| if (length > short.MaxValue || length < 0) |
There was a problem hiding this comment.
Suggested change
| if (length > short.MaxValue || length < 0) | |
| if (length is < 0 or > short.MaxValue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand, the length argument cannot be negative in practice, it is a cosmetic check.
Found by Linux Verification Center (linuxtesting.org) with SVACE.