Skip to content

Draft: RFC 6761 handling for invalid and *.localhost #120376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Draft: RFC 6761 handling for invalid and *.localhost #120376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,19 @@ private static object GetHostEntryOrAddressesCore(string hostName, bool justAddr
return resultOnFailure;
}

if (hostName.Equals("invalid", StringComparison.OrdinalIgnoreCase) ||
hostName.EndsWith(".invalid", StringComparison.OrdinalIgnoreCase))
{
throw new SocketException((int)SocketError.HostNotFound);
}

if (hostName.Equals("localhost", StringComparison.OrdinalIgnoreCase) ||
hostName.EndsWith(".localhost", StringComparison.OrdinalIgnoreCase))
{
IPAddress[] loopbacks = new IPAddress[] { IPAddress.Loopback, IPAddress.IPv6Loopback };
return justAddresses ? (object)loopbacks : new IPHostEntry { AddressList = loopbacks, HostName = hostName, Aliases = Array.Empty<string>() };
}

// NameResolutionActivity may have already been set if we're being called from RunAsync.
NameResolutionActivity activity = activityOrDefault ?? NameResolutionTelemetry.Log.BeforeResolution(hostName);

Expand Down
Loading