JIT: if IR and stack can't provide a ref class handle, use object #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases we may end up in `lvaSetClass` without a valid ref class handle from either the IR or the stack. Use the handle for `object` as a conservative fallback. Closes dotnet/coreclr#27923.
|
cc @dotnet/jit-contrib |
maryamariyan
added
the
area-CodeGen-coreclr
AndyAyersMS
added a commit
to AndyAyersMS/coreclr
that referenced
this pull request
Dec 16, 2019
Fix for #27923 The jit might fail to locate a class handle for a ref class, leading to an unexpected crash while jitting. ## Customer Impact Unexpected and hard to diagnose crash/exception ## Regression? Yes, introduced during the development 3.0 cycle. 2.x behaves correctly. ## Testing Verified the user's test case now passes; no diffs seen in any existing framework or test code. ## Risk **Low**: the jit will now fall back to using the handle for System.Object if no better option can be found. cc @BruceForstall ____ In some cases we may end up in lvaSetClass without a valid ref class handle from either the IR or the stack. Use the handle for object as a conservative fallback.
Anipik
pushed a commit
to dotnet/coreclr
that referenced
this pull request
Jan 14, 2020
Fix for #27923 The jit might fail to locate a class handle for a ref class, leading to an unexpected crash while jitting. ## Customer Impact Unexpected and hard to diagnose crash/exception ## Regression? Yes, introduced during the development 3.0 cycle. 2.x behaves correctly. ## Testing Verified the user's test case now passes; no diffs seen in any existing framework or test code. ## Risk **Low**: the jit will now fall back to using the handle for System.Object if no better option can be found. cc @BruceForstall ____ In some cases we may end up in lvaSetClass without a valid ref class handle from either the IR or the stack. Use the handle for object as a conservative fallback.
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Nov 4, 2020
An interface call with a null `this` needs to throw a `NullReferenceException`. There are two ways to achieve that: either codegen can insert explicit code to trigger a NullRef at the callsite (before calling into the runtime library to do the dispatch), or the runtime library needs to be able to unwind the helper code that tries to resolve the dispatch and blame the callsite. .NET Native did the former, but the latter produces smaller code (no need to insert the checks). The CoreRT runtime doesn't have code to handle the latter. This pull request is adding that. The fix is relatively straightforward - we mark locations in the helper where AV can occur. If an AV occurs outside managed code, we check whether it's one of the known locations. If so, we remove the helper method frame off the stack and pretend the AV happened in the calling code. The one-liner fix in CorInfoImpl fixes an unintialized value problem that basically made us roll a dice on whether to do an explicit nullcheck at the callsite. Fixes dotnet#221.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases we may end up in
lvaSetClasswithout a valid ref class handlefrom either the IR or the stack. Use the handle for
objectas a conservativefallback.
Closes dotnet/coreclr#27923 (aka #13817)