add nx plugin #50984

AgentEnder · 2025-09-24T18:17:00Z

No description provided.

This commit sets up Nx Cloud for your Nx workspace, enabling distributed caching and the Nx Cloud GitHub integration for fast CI and improved developer experience. You can access your Nx Cloud workspace by going to https://staging.nx.app/orgs/67cf576f7df53b293055263b/workspaces/68d433e5997fbc40b28ff0d7 **Note:** This commit attempts to maintain formatting of the nx.json file, however you may need to correct formatting by running an nx format command and committing the changes.

feat(nx-cloud): set up nx workspace

github-actions · 2025-09-24T18:17:09Z

This PR is targeting main, which is now for .NET 11-facing work. If you intended to target .NET 10, either retarget this PR to release/10.0.1xx or make sure you backport the change to release/10.0.1xx after merging. See #50394 for more details.

Copilot

Pull Request Overview

This PR adds an Nx plugin to provide build orchestration and project graph functionality for .NET SDK projects. The main purpose is to integrate Nx tooling to manage the complex build dependencies within the .NET SDK repository.

Key changes include:

Custom Nx plugin implementation for detecting and building .NET projects
TypeScript configuration for the plugin build system
GitHub workflow for comparing Nx vs traditional build performance
Project configuration files to enable Nx workspace functionality

Reviewed Changes

Copilot reviewed 200 out of 202 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
tools/nx-plugin/src/index.ts	Core plugin implementation with project detection and target generation for .NET projects
tsconfig.base.json	Base TypeScript configuration with path mapping for the nx-plugin
tools/nx-plugin/tsconfig*.json	TypeScript configuration files for the plugin build
tools/nx-plugin/project.json	Nx project configuration for the plugin with build targets
tools/nx-plugin/package.json	Package definition for the plugin library
nx.json	Nx workspace configuration enabling the custom plugin
package.json	Root package.json with Nx dependencies
.github/workflows/nx-comparison.yml	GitHub Actions workflow to compare build performance
research/redist-build-analysis.md	Documentation explaining build dependency issues
.prettierrc/.prettierignore	Code formatting configuration
src/Layout/redist/*/project.json	Project configuration files for redist components
.claude/settings.local.json	Local settings for development tools

Copilot · 2025-09-24T18:19:03Z

tools/nx-plugin/src/index.ts

+    const filename =
+        basename(configFilePath, '.csproj') ||
+        basename(configFilePath, '.fsproj') ||
+        basename(configFilePath, '.vbproj');


The logical OR operator will return the first truthy value, but basename(configFilePath, '.csproj') will always return a string (potentially the full filename if extension doesn't match). This means the .fsproj and .vbproj cases will never be reached. Use parse(configFilePath).name instead to get the filename without extension.

Copilot · 2025-09-24T18:19:04Z

tools/nx-plugin/src/index.ts

+    const nameWithoutExtension =
+        basename(projectFileName, '.csproj') ||
+        basename(projectFileName, '.fsproj') ||
+        basename(projectFileName, '.vbproj');


Same issue as in inferProjectName - the logical OR operator will not work as expected since basename() always returns a string. The second and third calls will never execute. Use parse(projectFileName).name to get the filename without extension.

Suggested change

const nameWithoutExtension =

basename(projectFileName, '.csproj') ||

basename(projectFileName, '.fsproj') ||

basename(projectFileName, '.vbproj');

const nameWithoutExtension = parse(projectFileName).name;

Copilot · 2025-09-24T18:19:04Z

.github/workflows/nx-comparison.yml

+          echo "Without Nx DTE Job Duration: $(( ${{ needs.withoutNx.outputs.end_time }} - ${{ needs.withoutNx.outputs.start_time }} )) seconds"
+          echo "With Nx DTE Job Duration: $(( ${{ needs.main.outputs.end_time }} - ${{ needs.main.outputs.start_time }} )) seconds"


The job outputs are not being set in the workflow. The withoutNx and main jobs record start_time and end_time but don't expose them as job outputs. Add outputs: sections to both jobs with the timing values.

Copilot · 2025-09-24T18:19:05Z

tools/nx-plugin/src/index.ts

+        const output = execSync(`dotnet list "${projectFile}" reference`, {
+            cwd: this.workspaceRoot,
+            encoding: 'utf8',
+            windowsHide: true,
+        });
+
+        return output
+            .split('\n')
+            .slice(2) // Skip header lines
+            .map((line) => line.trim())
+            .filter((line) => line.length > 0);


The execSync call doesn't handle potential errors from the dotnet command. If the project file doesn't exist or dotnet fails, this will throw an uncaught exception. Wrap in try-catch and return empty array on failure, or provide a more descriptive error message.

Suggested change

const output = execSync(`dotnet list "${projectFile}" reference`, {

cwd: this.workspaceRoot,

encoding: 'utf8',

windowsHide: true,

});

return output

.split('\n')

.slice(2) // Skip header lines

.map((line) => line.trim())

.filter((line) => line.length > 0);

try {

const output = execSync(`dotnet list "${projectFile}" reference`, {

cwd: this.workspaceRoot,

encoding: 'utf8',

windowsHide: true,

});

return output

.split('\n')

.slice(2) // Skip header lines

.map((line) => line.trim())

.filter((line) => line.length > 0);

} catch (error) {

logger.warn(

`Failed to get project references for ${projectFile}: ${error instanceof Error ? error.message : error}`

);

return [];

}

Copilot · 2025-09-24T18:19:05Z

tools/nx-plugin/src/index.ts

+                },
+                dependsOn: [`^${options.restoreTargetName}`],
+                cache: true,
+                inputs: ['{projectRoot}/' + fileName],


String concatenation should use template literals or join() for better readability and consistency with the rest of the codebase. Change to inputs: [\{projectRoot}/${fileName}`]`.

Suggested change

inputs: ['{projectRoot}/' + fileName],

inputs: [`{projectRoot}/${fileName}`],

AgentEnder · 2025-09-24T18:19:25Z

This was an accident - ignore me

dotnet-policy-service · 2025-09-24T18:20:23Z

@AgentEnder please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ),
and conveys certain license rights to the .NET Foundation ( “.NET Foundation” ) for Your contributions to
.NET Foundation open source projects. This Agreement is effective as of the latest signature date below.

1. Definitions.

“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to .NET Foundation under this Agreement.

“Project” means any of the projects owned or managed by .NET Foundation and offered under a license
approved by the Open Source Initiative (www.opensource.org).

“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”

“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.

2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.

3. Originality of Work. You represent that each of Your Submissions is entirely Your
original work. Should You wish to Submit materials that are not Your original work,
You may Submit them separately to the Project if You (a) retain all copyright and
license information that was in the materials as you received them, (b) in the
description accompanying your Submission, include the phrase "Submission
containing materials of a third party:" followed by the names of the third party and any
licenses or other restrictions of which You are aware, and (c) follow any other
instructions in the Project's written guidelines concerning Submissions.

4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.

5. Licenses.

a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly
or indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable
license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform,
and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing
rights to third parties.

b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or
indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license
under Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.

c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

6. Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3 ). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6 , THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.

7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or
circumstances of which You later become aware that would make Your representations in this
Agreement inaccurate in any respect.

8. Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.

9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.

10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by .NET Foundation.

.NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1.

AgentEnder added 4 commits September 12, 2025 14:51

add nx plugin

982639b

chore: working build

e7e276b

Merge pull request #1 from AgentEnder/feat/nx-cloud/setup

d3e67aa

feat(nx-cloud): set up nx workspace

Copilot AI review requested due to automatic review settings September 24, 2025 18:17

chore: remove other pipelines

d9b4a75

Copilot AI reviewed Sep 24, 2025

View reviewed changes

AgentEnder closed this Sep 24, 2025

This was referenced Sep 24, 2025

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

Unable to checkout dotnet/dnceng#4115

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add nx plugin #50984

add nx plugin #50984

Uh oh!

AgentEnder commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 24, 2025

Uh oh!

Copilot AI Sep 24, 2025

Uh oh!

Copilot AI Sep 24, 2025

Uh oh!

Copilot AI Sep 24, 2025

Uh oh!

Copilot AI Sep 24, 2025

Uh oh!

AgentEnder commented Sep 24, 2025

Uh oh!

dotnet-policy-service bot commented Sep 24, 2025

Contribution License Agreement

Uh oh!

Uh oh!

		echo "Without Nx DTE Job Duration: $(( ${{ needs.withoutNx.outputs.end_time }} - ${{ needs.withoutNx.outputs.start_time }} )) seconds"
		echo "With Nx DTE Job Duration: $(( ${{ needs.main.outputs.end_time }} - ${{ needs.main.outputs.start_time }} )) seconds"

	inputs: ['{projectRoot}/' + fileName],
	inputs: [`{projectRoot}/${fileName}`],

add nx plugin #50984

add nx plugin #50984

Uh oh!

Conversation

AgentEnder commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

AgentEnder commented Sep 24, 2025

Uh oh!

dotnet-policy-service bot commented Sep 24, 2025

Contribution License Agreement

Uh oh!

Uh oh!