Arcade powered source build phase 1 and 2 #235
Conversation
| <Project> | ||
|
|
||
| <PropertyGroup> | ||
| <GitHubRepositoryName>symreader</GitHubRepositoryName> |
There was a problem hiding this comment.
symreader [](start = 4, length = 54)
Can't this be inferred from git info?
There was a problem hiding this comment.
Potentially, but it doesn't seem like something worth implementing right now. There are risks, and it would be easy to fix incrementally later on. I've filed dotnet/source-build#2029 with some more info and to track this.
|
I forgot to do a pass over patches when I opened this PR, but looking at it now, I see that both https://github.com/dotnet/source-build/blob/release/5.0/patches/symreader/0001-Add-initial-Arcade-SDK-switchover.patch and https://github.com/dotnet/source-build/blob/release/5.0/patches/symreader/0002-Fix-license-per-Arcade-SDK-expectations.patch have already been merged. |
omajid
force-pushed
the
arcade-powered-source-build-1-and-2
branch
from
9c92fa5
to
1f2fd62
Compare
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source. This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md See dotnet/sourcelink#692 for a similar PR, that this is based on.
omajid
force-pushed
the
arcade-powered-source-build-1-and-2
branch
from
1f2fd62
to
2047f21
Compare
|
Thanks, @tmat! I have rebased this branch on top of |
|
Thanks for merging this! |
This PR includes #234 and needs to be fixed up after that's merged.
This enables 'source-build', which makes it easier to build the entire shipping .NET SDK from source.
This is the first and second step of arcade-powered-source-build: https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md
See dotnet/sourcelink#692 for a similar PR, that this is based on.
cc @tmat @dagood