Skip to content

Support alternative lz4framed #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 9, 2018
Merged

Support alternative lz4framed #1395

merged 3 commits into from
Mar 9, 2018

Conversation

everpcpc
Copy link
Contributor

@jeffwidman
Copy link
Contributor

Are there tests that should also be updated to run using this new library as well?

@everpcpc everpcpc force-pushed the lz4 branch 6 times, most recently from 627e06a to 631ae2f Compare February 28, 2018 09:25
@everpcpc
Copy link
Contributor Author

everpcpc commented Mar 6, 2018 •
edited
Loading

I replaced lz4 with py-lz4framed in the test and it seems OK with travis-ci. I'll change it back later.
It's maybe not necessary to add tests for this. Because lz4f is also not test.
Testing both would take too long based on current tests.

@dpkp dpkp merged commit 5446d18 into dpkp:master Mar 9, 2018
@dpkp
Copy link
Owner

dpkp commented Mar 9, 2018

Looks great, thanks!

@everpcpc everpcpc deleted the lz4 branch March 9, 2018 16:45
@jeffwidman jeffwidman mentioned this pull request Mar 16, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@everpcpc @jeffwidman @dpkp