Skip to content

Conversation

gabriel-tincu
Copy link
Contributor

@gabriel-tincu gabriel-tincu commented Mar 15, 2020

  • part 1 of adding zstd compression

This change is Reviewable

@gabriel-tincu
Copy link
Contributor Author

@jeffwidman As discussed, adding 2.1.0

Copy link
Contributor

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's a 2.1.1 bugfix release, can we use that instead?

https://downloads.apache.org/kafka/2.1.1/RELEASE_NOTES.html

And it's already available in our vendored servers, so this looks like the only place that needs updating.

@jeffwidman
Copy link
Contributor

And sorry, I should have caught this in the original review...

Copy link
Contributor

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@jeffwidman jeffwidman merged commit 5d4b3ec into dpkp:master Mar 16, 2020
@jeffwidman
Copy link
Contributor

Note that this only adds it to the available versions under build_integration.sh... Travis doesn't actually test this currently:

kafka-python/.travis.yml

Lines 12 to 17 in 1bb6b72

- KAFKA_VERSION=0.8.2.2
- KAFKA_VERSION=0.9.0.1
- KAFKA_VERSION=0.10.2.2
- KAFKA_VERSION=0.11.0.3
- KAFKA_VERSION=1.1.1
- KAFKA_VERSION=2.4.0

@hackaugusto hackaugusto deleted the gabi-zstd-compression-release-list branch January 11, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants