Skip to content

Allow configurable timeouts in admin client check version #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2020
Merged

Allow configurable timeouts in admin client check version #2107

merged 1 commit into from
Sep 17, 2020

Conversation

sunnyakaxd
Copy link
Contributor

@sunnyakaxd sunnyakaxd commented Aug 22, 2020 •
edited by dpkp
Loading

Currently there's no way to pass timeout to check_version if called from admin.

This change is Reviewable

@sunnyakaxd
Allow configurable timeouts in admin client check version
e71414c 
Currently there's no way to pass timeout to check_version if called from admin.
jeffwidman
jeffwidman approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@jeffwidman jeffwidman merged commit b32f369 into dpkp:master Sep 17, 2020
@jeffwidman jeffwidman mentioned this pull request Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jeffwidman jeffwidman jeffwidman approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunnyakaxd @jeffwidman