add international support for weather module #52
Conversation
It uses [wttr.in](https://github.com/chubin/wttr.in) to get the weather information and the current city based on the IP address
|
Nice, it's working for me |
There was a problem hiding this comment.
this is great. Only thing is I think we should keep it consistent with how it looked before.
So I think the only differences I see are:
- Instead of the normal unicode characters for forecast it is showing the emoji, it should just be the all black colored one so that it is easy to see with the orange background and matches the other characters. See the forecast_unicode() code block from the original weather.sh script
- No plus for positive degrees, only the minus for negative
- Instead of city, country, could we do city, region? We can get the region using ipinfo.io/region
|
Is ipinfo a global api? Also just my two cents, I think we should try and avoid using two external api’s |
Show unicode characters for forecast instead of an emoji. Remove the plus sign for positive degrees. Show city, region instead of city, country
|
@HugoLiconV what's the status on this? I would like to get this merged for you but it needs to be fully working :) Also, minor issue that we can solve with #42 is that currently the CPU and Weather module have a color conflict. Nothing wrong on your part we just need something to fix #42 :) |
Hi @ethancedwards8, the code should be working now, I did some changes but I didn't receive a response or review from @danerwilliams |
|
@HugoLiconV sorry I think I have changes requested still so that is why it hadn't been merged |
I updated the PR after you requested the changes, could you tell me what it's missing? |
|
Oh I'm not sure why but the change request didn't resolve. Either @ethancedwards8 or I need to test and confirm the change but otherwise it seems fine. |
|
It's working well for me. Since this is such a big change I think @danerwilliams should also test it out, then we can merge it if there's no issues. Just in case. |
|
I've been using it the past 2 days and it's worked great. Merging! :) |
|
In general, I use tmux on VPN'd connections on remote servers/clusters. As such, the IP-tied weather info isn't very relevant to me. I would like it to be though.. |
|
Is there a way to force the location ? The IP addressing plan of my ISP is not location based but national-wide so I get the weather from Paris instead of my city. |
|
I agree, forcing the location is needed when using a VPN. |
6 participants
It uses wttr.in to get the weather information and the current city based on the IP address
Solves issue #16