Remove usage of lookbehind regex expression #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
YoussefHenna
commented
Sep 30, 2024
YoussefHenna
commented
- The lookbehind regex is not supported on recent safari versions: https://caniuse.com/js-regexp-lookbehind, it only got support recently.
- This causes the builder to crash for people that have a slightly older version of safari. Safari also requires mac os upgrades to update, so some users might not be able to update their macos or safari and would therefore never be able to access the builder.
- I couldn't figure out a regex that does not use the lookbehind, so this is the approach I went with, but let me know if you have other suggestions.
- Not supported on recent safari versions: https://caniuse.com/js-regexp-lookbehind
needs
reviewed
Sep 30, 2024
adnelson
approved these changes
Sep 30, 2024
|
Although if @needs suggestion works, that's great too :) |
|
Managed to use regex groups to keep the implementation using regex. |
needs
approved these changes
Oct 1, 2024
| @@ -35,7 +35,7 @@ let parseVJsonWithVariable = parseVariableString => { | |||
| regex(inQuotesRegex) | |||
| |> map(match => { | |||
| match | |||
| ->Js.String2.replaceByRe(nonEsacapedQuoteRegex, ``) | |||
| ->Js.String2.replaceByRe(nonEscapedQuoteRegex, `$1`) // First group of the regex is characters before the quote that should be kept | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.