Skip to content

Remove usage of lookbehind regex expression #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Remove usage of lookbehind regex expression #3

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c274d3e
Remove usage of lookbehind regex expression
YoussefHenna Sep 30, 2024
bc527b7
Revert "Remove usage of lookbehind regex expression"
YoussefHenna Oct 1, 2024
a50e2b5
Update regex and re-add group when replacing
YoussefHenna Oct 1, 2024
320833f
typo
YoussefHenna Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/VJsonParse.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ let parseVJsonWithVariable = parseVariableString => {
\"<|>"(str("true") |> map(_ => true), str("false") |> map(_ => false)) |> lexeme

let escapedQuoteRegex = %re(`/\\\\"/gm`)
let nonEsacapedQuoteRegex = %re(`/(?<!\\\\)(?:\\\\{2})*"/gm`)
let nonEscapedQuoteRegex = %re(`/((?:^|[^\\\\])(?:\\\\{2})*)"/gm`)
let inQuotesRegex = %re(`/"(?:[^"\\\\]|\\\\.)*"/`)
// Parse a string. Allows for escaped quotes.
// NOTE: not to be confused with `parse`, which takes a raw string and parses
Expand All @@ -35,7 +35,7 @@ let parseVJsonWithVariable = parseVariableString => {
regex(inQuotesRegex)
|> map(match => {
match
->Js.String2.replaceByRe(nonEsacapedQuoteRegex, ``)
->Js.String2.replaceByRe(nonEscapedQuoteRegex, `$1`) // First group of the regex is characters before the quote that should be kept
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

->Js.String2.replaceByRe(escapedQuoteRegex, `"`)
})
|> lexeme
Expand Down