Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake): look for pkg-config when building grpc #1470

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Aug 8, 2019

Find pkg-config sooner than later, to avoid people to stumble into this error:

[ 40%] Performing patch step for 'grpc'
--2019-08-06 22:19:23--  https://download.sysdig.com/dependencies/grpc-1.8.1-Makefile.patch
Resolving download.sysdig.com (download.sysdig.com)... 54.230.117.108, 54.230.117.175, 54.230.117.33, ...
Connecting to download.sysdig.com (download.sysdig.com)|54.230.117.108|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 673 [binary/octet-stream]
Saving to: 'grpc-1.8.1-Makefile.patch'

grpc-1.8.1-Makefile.patch  100%[======================================>]     673  --.-KB/s    in 0s

2019-08-06 22:19:24 (59.0 MB/s) - 'grpc-1.8.1-Makefile.patch' saved [673/673]

patching file Makefile
[ 40%] No update step for 'grpc'
[ 40%] No configure step for 'grpc'
[ 41%] Performing build step for 'grpc'

DEPENDENCY ERROR

The target you are trying to run requires protobuf 3.0.0+
Your system doesn't have it, and neither does the third_party directory.

Please consult INSTALL to get more information.

If you need information about why these tests failed, run:

  make run_dep_checks

Signed-off-by: Lorenzo Fontana lo@linux.com

Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz fntlnz requested review from gnosek and ldegio August 8, 2019 09:30
@leodido leodido self-requested a review August 8, 2019 23:51
@fntlnz fntlnz merged commit 9e12e2f into dev Aug 9, 2019
@fntlnz fntlnz deleted the build/find-pkgconfig branch August 9, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants