Skip to content

Commit 2afc5cf

Browse files
committed
fix(module-loader): null references
1 parent 45e71a6 commit 2afc5cf

File tree

1 file changed

+17
-15
lines changed

1 file changed

+17
-15
lines changed

src/util/module-loader.ts

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -75,24 +75,26 @@ export interface LoadedModule {
7575
* @hidden
7676
*/
7777
export function setupPreloadingImplementation(config: Config, deepLinkConfig: DeepLinkConfig, moduleLoader: ModuleLoader): Promise<any> {
78-
if (config.getBoolean('preloadModules') && deepLinkConfig && deepLinkConfig.links) {
79-
const linksToLoad = deepLinkConfig.links.filter(link => !!link.loadChildren && link.priority !== 'off');
78+
if (!deepLinkConfig || !deepLinkConfig.links || !config.getBoolean('preloadModules')) {
79+
return Promise.resolve();
80+
}
81+
const linksToLoad = deepLinkConfig.links.filter(link => !!link.loadChildren && link.priority !== 'off');
82+
83+
// Load the high priority modules first
84+
const highPriorityPromises = linksToLoad
85+
.filter(link => link.priority === 'high')
86+
.map(link => moduleLoader.load(link.loadChildren));
8087

81-
// Load the high priority modules first
82-
const highPriorityPromises = linksToLoad.filter(link => link.priority === 'high')
88+
return Promise.all(highPriorityPromises).then(() => {
89+
// Load the low priority modules after the high priority are done
90+
const lowPriorityPromises = linksToLoad
91+
.filter(link => link.priority === 'low')
8392
.map(link => moduleLoader.load(link.loadChildren));
8493

85-
return Promise.all(highPriorityPromises).then(() => {
86-
// Load the low priority modules after the high priority are done
87-
const lowPriorityPromises = linksToLoad.filter(link => link.priority === 'low')
88-
.map(link => moduleLoader.load(link.loadChildren));
89-
return Promise.all(lowPriorityPromises);
90-
}).catch(err => {
91-
console.error(err.message);
92-
});
93-
} else {
94-
return Promise.resolve();
95-
}
94+
return Promise.all(lowPriorityPromises);
95+
}).catch(err => {
96+
console.error(err.message);
97+
});
9698
}
9799

98100
/**

0 commit comments

Comments
 (0)