Skip to content

Commit 6496c7a

Browse files
committed
fix(nav): remove incorrectly used removeStart as a starting index in for loop. Fixes #8442
1 parent 88da70c commit 6496c7a

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

src/navigation/nav-controller-base.ts

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ export class NavControllerBase extends Ion implements NavController {
237237

238238
this._queue.push(ti);
239239

240-
// if there isn't a transitoin already happening
240+
// if there isn't a transition already happening
241241
// then this will kick off this transition
242242
this._nextTrns();
243243

@@ -287,8 +287,8 @@ export class NavControllerBase extends Ion implements NavController {
287287

288288
leavingRequiresTransition = (ti.removeStart + ti.removeCount === viewsLength);
289289

290-
for (var i = ti.removeStart; i <= ti.removeCount; i++) {
291-
destroyQueue.push(this._views[i]);
290+
for (var i = 0; i < ti.removeCount; i++) {
291+
destroyQueue.push(this._views[i + ti.removeStart]);
292292
}
293293

294294
for (var i = viewsLength - 1; i >= 0; i--) {
@@ -914,6 +914,13 @@ export class NavControllerBase extends Ion implements NavController {
914914
return this._views.length;
915915
}
916916

917+
/**
918+
* Return the stack of views in this NavController.
919+
*/
920+
getViews(): Array<ViewController> {
921+
return this._views;
922+
}
923+
917924
isSwipeBackEnabled(): boolean {
918925
return this._sbEnabled;
919926
}

src/navigation/nav-controller.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -486,6 +486,13 @@ export abstract class NavController {
486486
*/
487487
abstract length(): number;
488488

489+
490+
/**
491+
* Returns the current stack of views in this nav controller.
492+
* @returns {Array<ViewController>} the stack of view controllers in this nav controller.
493+
*/
494+
abstract getViews(): Array<ViewController>;
495+
489496
/**
490497
* Returns the active child navigation.
491498
*/

0 commit comments

Comments
 (0)