fix(menu): fix scrolling page w/ side menus

adamdbradley · adamdbradley · commit 72699dbbb425 · 2016-02-02T16:41:35.000-06:00
Improved which angles should allow the side menu to open, depending if it’s a left or right menu. Also check if the distance of the drag is longer than a side menu would get. For example, scrolling vertically for a long ways would have a long distance, but triggering a side menu to open would be a short distance. Also ensure that a side menu can always be closed incase something goes wrong. Closes #5272
diff --git a/ionic/components/menu/menu-gestures.ts b/ionic/components/menu/menu-gestures.ts
@@ -3,7 +3,6 @@ import {SlideEdgeGesture} from '../../gestures/slide-edge-gesture';
 
 import {assign} from '../../util/util';
 
-
 export class MenuContentGesture extends SlideEdgeGesture {
 
   constructor(public menu: Menu, targetEl: Element, options = {}) {
@@ -19,8 +18,36 @@ export class MenuContentGesture extends SlideEdgeGesture {
   }
 
   canStart(ev) {
-    let validAngle = ((-35 <= ev.angle && ev.angle <= 35) || (180 >= ev.angle && ev.angle >= 145) || (-180 <= ev.angle && ev.angle <= -145));
-    return this.menu.isOpen && this.menu.isEnabled && validAngle ? true : super.canStart(ev);
+    let menu = this.menu;
+
+    console.debug('menu canStart, id', menu.id, 'angle', ev.angle, 'distance', ev.distance);
+
+    if (!menu.isEnabled || !menu.isSwipeEnabled) {
+      console.debug('menu canStart, isEnabled', menu.isEnabled, 'isSwipeEnabled', menu.isSwipeEnabled, 'id', menu.id);
+      return false;
+    }
+
+    if (ev.distance > 50) {
+      // the distance is longer than you'd expect a side menu swipe to be
+      console.debug('menu canStart, distance too far', ev.distance, 'id', menu.id);
+      return false;
+    }
+
+    if (menu.side === 'left') {
+      // left side menu
+      if (ev.angle > -40 && ev.angle < 40) {
+        return super.canStart(ev);
+      }
+
+    } else if (menu.side === 'right') {
+      // right side menu
+      if ((ev.angle > 140 && ev.angle <= 180) || (ev.angle > -140 && ev.angle <= -180)) {
+        return super.canStart(ev);
+      }
+    }
+
+    // didn't pass the test, don't open this menu
+    return false;
   }
 
   // Set CSS, then wait one frame for it to apply before sliding starts
diff --git a/ionic/components/menu/menu.ts b/ionic/components/menu/menu.ts
@@ -282,7 +282,7 @@ export class Menu extends Ion {
   setOpen(shouldOpen) {
     // _isPrevented is used to prevent unwanted opening/closing after swiping open/close
     // or swiping open the menu while pressing down on the menuToggle button
-    if (shouldOpen === this.isOpen || this._isPrevented()) {
+    if ((shouldOpen && this.isOpen) || this._isPrevented()) {
       return Promise.resolve();
     }
 
diff --git a/ionic/components/menu/test/basic/index.ts b/ionic/components/menu/test/basic/index.ts
@@ -64,8 +64,8 @@ class E2EApp {
     console.log('onMenuOpening', ev);
   }
 
-  isHidden() {
+  isChangeDetecting() {
     console.log('Change detection', ++this.changeDetectionCount);
-    return false;
+    return true;
   }
 }
diff --git a/ionic/components/menu/test/basic/main.html b/ionic/components/menu/test/basic/main.html
@@ -1,4 +1,4 @@
-<ion-menu [content]="content" id="leftMenu" side="left" (opening)="onMenuOpening($event)">
+<ion-menu [content]="content" id="leftMenu" side="left">
 
   <ion-toolbar secondary>
     <ion-title>Left Menu</ion-title>
@@ -12,7 +12,51 @@
         {{p.title}}
       </button>
 
-      <button ion-item menuClose="leftMenu" detail-none [hidden]="isHidden()">
+      <button ion-item menuClose="leftMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="leftMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="leftMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="leftMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="leftMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="leftMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="leftMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="leftMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="leftMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="leftMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="leftMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="leftMenu" detail-none>
         Close Menu
       </button>
 
@@ -40,9 +84,60 @@
         Close Menu
       </button>
 
+      <button ion-item menuClose="rightMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="rightMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="rightMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="rightMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="rightMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="rightMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="rightMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="rightMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="rightMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="rightMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="rightMenu" detail-none>
+        Close Menu
+      </button>
+
+      <button ion-item menuClose="rightMenu" detail-none>
+        Close Menu
+      </button>
+
     </ion-list>
+
   </ion-content>
 
 </ion-menu>
 
 <ion-nav id="nav" [root]="rootView" #content swipe-back-enabled="false"></ion-nav>
+
+<div [hidden]="isChangeDetecting()"></div>
diff --git a/ionic/components/menu/test/basic/page1.html b/ionic/components/menu/test/basic/page1.html
@@ -51,4 +51,6 @@ <h3>Page 1</h3>
     <button (click)="presentAlert()">Open alert</button>
   </p>
 
+  <f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f><f></f>
+
 </ion-content>

Original file line number	Diff line number	Diff line change
`@@ -282,7 +282,7 @@ export class Menu extends Ion {`
`282`	`282`	`setOpen(shouldOpen) {`
`283`	`283`	`// _isPrevented is used to prevent unwanted opening/closing after swiping open/close`
`284`	`284`	`// or swiping open the menu while pressing down on the menuToggle button`
`285`		`- if (shouldOpen === this.isOpen \|\| this._isPrevented()) {`
	`285`	`+ if ((shouldOpen && this.isOpen) \|\| this._isPrevented()) {`
`286`	`286`	`return Promise.resolve();`
`287`	`287`	`}`
`288`	`288`
Original file line number	Diff line number	Diff line change
`@@ -64,8 +64,8 @@ class E2EApp {`
`64`	`64`	`console.log('onMenuOpening', ev);`
`65`	`65`	`}`
`66`	`66`
`67`		`- isHidden() {`
	`67`	`+ isChangeDetecting() {`
`68`	`68`	`console.log('Change detection', ++this.changeDetectionCount);`
`69`		`- return false;`
	`69`	`+ return true;`
`70`	`70`	`}`
`71`	`71`	`}`