Skip to content

Commit 7583ebf

Browse files
committed
fix(checkbox): add 'type="button"' to <button> tag
Add attribute 'type="button"' to <button> tag. The missing attribute caused forms with ion-checkboxes to not be submitted as a normal form
1 parent dad2155 commit 7583ebf

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

ionic/components/checkbox/checkbox.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ const CHECKBOX_VALUE_ACCESSOR = new Provider(
5454
'<div class="checkbox-inner"></div>' +
5555
'</div>' +
5656
'<button role="checkbox" ' +
57+
'type="button" ' +
5758
'[id]="id" ' +
5859
'[attr.aria-checked]="_checked" ' +
5960
'[attr.aria-labelledby]="_labelId" ' +

0 commit comments

Comments
 (0)