Skip to content

Commit b24dc27

Browse files
committed
fix(alert): update radio/checkbox items to buttons elements
1 parent 77b77d1 commit b24dc27

File tree

5 files changed

+15
-7
lines changed

5 files changed

+15
-7
lines changed

ionic/components/alert/alert.ios.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ $alert-ios-checkbox-icon-checkmark-color: $background-ios-color !default;
142142
.alert-tappable {
143143
display: flex;
144144
min-height: $alert-ios-button-min-height;
145-
cursor: pointer;
146145
}
147146

148147

ionic/components/alert/alert.md.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ $alert-md-button-text-align: right !default;
127127
overflow: hidden;
128128
display: flex;
129129
min-height: 44px;
130-
cursor: pointer;
131130
}
132131

133132

ionic/components/alert/alert.scss

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,3 +78,14 @@ ion-alert {
7878
line-height: $alert-button-line-height;
7979
font-size: $alert-button-font-size;
8080
}
81+
82+
.alert-tappable {
83+
margin: 0;
84+
padding: 0;
85+
width: 100%;
86+
font-size: inherit;
87+
line-height: initial;
88+
text-align: left;
89+
background: transparent;
90+
-webkit-appearance: none;
91+
}

ionic/components/alert/alert.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -219,23 +219,23 @@ export class Alert extends ViewController {
219219

220220
'<template ngSwitchWhen="radio">' +
221221
'<div class="alert-radio-group" role="radiogroup" [attr.aria-labelledby]="hdrId" [attr.aria-activedescendant]="activeId">' +
222-
'<div *ngFor="#i of d.inputs" (click)="rbClick(i)" [attr.aria-checked]="i.checked" [attr.id]="i.id" class="alert-tappable alert-radio" tappable role="radio">' +
222+
'<button *ngFor="#i of d.inputs" (click)="rbClick(i)" [attr.aria-checked]="i.checked" [attr.id]="i.id" class="alert-tappable alert-radio" role="radio">' +
223223
'<div class="alert-radio-icon"></div>' +
224224
'<div class="alert-radio-label">' +
225225
'{{i.label}}' +
226226
'</div>' +
227-
'</div>' +
227+
'</button>' +
228228
'</div>' +
229229
'</template>' +
230230

231231
'<template ngSwitchWhen="checkbox">' +
232232
'<div class="alert-checkbox-group">' +
233-
'<div *ngFor="#i of d.inputs" (click)="cbClick(i)" [attr.aria-checked]="i.checked" class="alert-tappable alert-checkbox" tappable role="checkbox">' +
233+
'<button *ngFor="#i of d.inputs" (click)="cbClick(i)" [attr.aria-checked]="i.checked" class="alert-tappable alert-checkbox" role="checkbox">' +
234234
'<div class="alert-checkbox-icon"><div class="alert-checkbox-inner"></div></div>' +
235235
'<div class="alert-checkbox-label">' +
236236
'{{i.label}}' +
237237
'</div>' +
238-
'</div>' +
238+
'</button>' +
239239
'</div>' +
240240
'</template>' +
241241

ionic/components/alert/alert.wp.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,6 @@ ion-alert {
143143
overflow: hidden;
144144
display: flex;
145145
min-height: 44px;
146-
cursor: pointer;
147146
}
148147

149148

0 commit comments

Comments
 (0)