Skip to content

Commit d531ec2

Browse files
manucorporatbrandyscarney
authored andcommitted
perf(menu): avoid change detection when it isn't needed (#8986)
1 parent cf1196a commit d531ec2

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/components/menu/menu-gestures.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ export class MenuContentGesture extends SlideEdgeGesture {
2121
threshold: 0,
2222
maxEdgeStart: menu.maxEdgeStart || 50,
2323
maxAngle: 40,
24+
zone: false,
2425
debouncer: new NativeRafDebouncer(),
2526
gesture: gestureCtrl.create('menu-swipe', {
2627
priority: GesturePriority.MenuSwipe,
@@ -58,7 +59,6 @@ export class MenuContentGesture extends SlideEdgeGesture {
5859
'z', z,
5960
'stepValue', stepValue);
6061

61-
ev.preventDefault();
6262
this.menu.swipeProgress(stepValue);
6363
}
6464

src/components/menu/menu.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,11 @@ export class Menu {
450450
return;
451451
}
452452
this._getType().setProgessStep(stepValue);
453-
this.ionDrag.emit(stepValue);
453+
454+
let ionDrag = this.ionDrag;
455+
if (ionDrag.observers.length > 0) {
456+
this._zone.run(ionDrag.emit.bind(ionDrag, stepValue));
457+
}
454458
}
455459

456460
/**

0 commit comments

Comments
 (0)