Attribute handler refactoring #426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames some things late in the game:
on_attribute
toadd_attribute_listener
on_message
toadd_message_listener
attribute_listener
toon_attribute
message_listener
toon_message
This creates more parity between
add_attribute_listener
andremove_attribute_listener
, which attach and remove functions, and the simple shorthand / decorateon_attribute
which would be pretty difficult to remove.notify_attribute_listeners
andnotify_message_listeners
publicAs per request.
See #61. Function prototype is now:
def listener(vehicle, attr_name, value)