Skip to content

Expose configuration entities #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Expose configuration entities #299

wants to merge 3 commits into from

Conversation

peterkeppert
Copy link
Contributor

No description provided.

@peterkeppert peterkeppert changed the title Add generated schema for config entities Add graphql_config module Sep 3, 2017
@peterkeppert peterkeppert mentioned this pull request Sep 3, 2017
Closed
@fubhy
Copy link
Contributor

fubhy commented Sep 3, 2017

Wow, nice job! I am currently on vacation so I will leave the review to @pmelab for now. But it looks very solid at a first glance.

@fubhy fubhy changed the title Add graphql_config module Expose configuration entities Sep 26, 2017
@fubhy fubhy mentioned this pull request Oct 16, 2017
Closed
@wimleers
Copy link

You'll want to omit the _core key. Core REST did the same: https://www.drupal.org/node/2915414.

@davidwhthomas
Copy link
Contributor

davidwhthomas commented Dec 14, 2017 •
edited
Loading

Thanks for the effort on this area. Being able to query configuration entities is a great feature to have. I did some local dev tests of the patch and found a couple of issues:

  • graphql_camelcase and graphql_propcase are now in StringHelper utility
  • Some change to the GraphQL namespace of TypePluginBase and FieldPluginBase

I made a couple of small tweaks. Here's the patch to the graphql_config module: 299.patch.txt (let me know if better place to put the patch)

After this, I could successfully query my selected configuration entities.

Hopefully that helps.

@fubhy
Copy link
Contributor

fubhy commented Jan 25, 2018

I have started working on this including config property derivers in #477

@fubhy fubhy closed this Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmelab pmelab Awaiting requested review from pmelab

@scrutinizer-auto-fixer scrutinizer-auto-fixer Awaiting requested review from scrutinizer-auto-fixer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterkeppert @fubhy @wimleers @davidwhthomas