Skip to content

Conversation

fubhy
Copy link
Contributor

@fubhy fubhy commented Jan 23, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jan 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (8.x-3.x@c6b2195). Click here to learn what that means.
The diff coverage is 93.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##             8.x-3.x     #477   +/-   ##
==========================================
  Coverage           ?   81.55%           
==========================================
  Files              ?      245           
  Lines              ?     3752           
  Branches           ?        0           
==========================================
  Hits               ?     3060           
  Misses             ?      692           
  Partials           ?        0
Impacted Files Coverage Δ
...phQL/Fields/Entity/Config/ConfigEntityProperty.php 0% <0%> (ø)
.../src/Plugin/Deriver/Fields/EntityBundleDeriver.php 100% <100%> (ø)
...re/src/Plugin/Deriver/Fields/EntityByIdDeriver.php 100% <100%> (ø)
...e/src/Plugin/Deriver/Types/EntityBundleDeriver.php 100% <100%> (ø)
...c/Plugin/Deriver/Fields/EntityFieldItemDeriver.php 100% <100%> (ø)
...rc/Plugin/Deriver/Interfaces/EntityTypeDeriver.php 100% <100%> (ø)
...e/src/Plugin/Deriver/Fields/EntityFieldDeriver.php 93.1% <100%> (ø)
.../tests/src/Kernel/Entity/EntityBasicFieldsTest.php 100% <100%> (ø)
modules/graphql_core/src/TypeMapper.php 93.75% <87.5%> (ø)
.../src/Plugin/GraphQL/Fields/Entity/EntityBundle.php 93.75% <92.85%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b2195...b62641b. Read the comment docs.

@fubhy fubhy force-pushed the config-entities branch 6 times, most recently from 167328e to b08abe6 Compare January 25, 2018 15:03
@fubhy fubhy requested a review from pmelab January 25, 2018 16:19
@fubhy fubhy changed the title Adding support for config entities. Adding support for config entities Jan 25, 2018
@fubhy fubhy closed this Feb 16, 2018
@fubhy fubhy deleted the config-entities branch March 26, 2018 16:02
@davidwhthomas
Copy link
Contributor

davidwhthomas commented Apr 3, 2018

Hi @fubhy great to see the support for config entities in progress!
Just wondering, re: merge branch '8.x-3.x' into config-entities was it meant to be a merge from config-entities branch into 8.x-3.x?
It seems the merge was the other way around and I can't see the update in the codebase for the -dev release? https://github.com/drupal-graphql/graphql/tree/8.x-3.x/modules/graphql_core/src/Plugin/Deriver/Fields

@tguilpain
Copy link

Hi @fubhy , as @davidwhthomas says, this pull request is closed, it has not been merged anywhere. Has it been rejected or is it still going to be part of a next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants