Issue #3283794 by mondrake, longwave: Fix 'should return {type} but return statement is missing' PHPStan L0 errors in test code

(cherry picked from commit 9b485ec74db2dfe7c469a9990a7a6e5fe3658e11)

Author: alexpott

modules/block/tests/src/Functional/Rest/BlockResourceTestBase.php

@@ -109,6 +109,7 @@ protected function getExpectedNormalizedEntity() {
    */
   protected function getNormalizedPostEntity() {
     // @todo Update in https://www.drupal.org/node/2300677.
+    return [];
   }
 
   /**

modules/block_content/tests/src/Functional/Rest/BlockContentTypeResourceTestBase.php

@@ -66,6 +66,7 @@ protected function getExpectedNormalizedEntity() {
    */
   protected function getNormalizedPostEntity() {
     // @todo Update in https://www.drupal.org/node/2300677.
+    return [];
   }
 
 }

modules/comment/tests/src/Functional/CommentNonNodeTest.php

@@ -179,9 +179,7 @@ public function postComment(EntityInterface $entity, $comment, $subject = '', $c
       $this->assertArrayHasKey(1, $match);
     }
 
-    if (isset($match[1])) {
-      return Comment::load($match[1]);
-    }
+    return Comment::load($match[1]);
   }
 
   /**

modules/comment/tests/src/Functional/Rest/CommentResourceTestBase.php

@@ -317,16 +317,17 @@ public function testPostDxWithoutCriticalBaseFields() {
    */
   protected function getExpectedUnauthorizedAccessMessage($method) {
     switch ($method) {
-      case 'GET';
+      case 'GET':
         return "The 'access comments' permission is required and the comment must be published.";
 
-      case 'POST';
+      case 'POST':
         return "The 'post comments' permission is required.";
 
-      case 'PATCH';
+      case 'PATCH':
         return "The 'edit own comments' permission is required, the user must be the comment author, and the comment must be published.";
 
       case 'DELETE':
+      default:
         // \Drupal\comment\CommentAccessControlHandler::checkAccess() does not
         // specify a reason for not allowing a comment to be deleted.
         return '';

modules/comment/tests/src/Functional/Rest/CommentTypeResourceTestBase.php

@@ -72,6 +72,7 @@ protected function getExpectedNormalizedEntity() {
    */
   protected function getNormalizedPostEntity() {
     // @todo Update in https://www.drupal.org/node/2300677.
+    return [];
   }
 
 }

modules/config/tests/config_test/tests/src/Functional/Rest/ConfigTestResourceTestBase.php

@@ -68,6 +68,7 @@ protected function getExpectedNormalizedEntity() {
    */
   protected function getNormalizedPostEntity() {
     // @todo Update in https://www.drupal.org/node/2300677.
+    return [];
   }
 
   /**

modules/contact/tests/src/Functional/Rest/ContactFormResourceTestBase.php

@@ -85,6 +85,7 @@ protected function getExpectedNormalizedEntity() {
    */
   protected function getNormalizedPostEntity() {
     // @todo Update in https://www.drupal.org/node/2300677.
+    return [];
   }
 
   /**

modules/editor/tests/src/Functional/Rest/EditorResourceTestBase.php

@@ -122,6 +122,7 @@ protected function getExpectedNormalizedEntity() {
    */
   protected function getNormalizedPostEntity() {
     // @todo Update in https://www.drupal.org/node/2300677.
+    return [];
   }
 
   /**

modules/field/tests/src/Functional/Rest/FieldConfigResourceTestBase.php

@@ -94,6 +94,7 @@ protected function getExpectedNormalizedEntity() {
    */
   protected function getNormalizedPostEntity() {
     // @todo Update in https://www.drupal.org/node/2300677.
+    return [];
   }
 
   /**

modules/field/tests/src/Functional/Rest/FieldStorageConfigResourceTestBase.php

@@ -73,6 +73,7 @@ protected function getExpectedNormalizedEntity() {
    */
   protected function getNormalizedPostEntity() {
     // @todo Update in https://www.drupal.org/node/2300677.
+    return [];
   }
 
   /**