fix: Workflow path is enumerated, but does not exist any longer #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When workflow definition files are deleted, but had runs in the past, the GitHub API still enumerates them as if they would exist. In reality, however, they are gone. This detail, however, only becomes apparent when accessing the workflow, so this patch compensates for corresponding 404 errors returned by the API.
cunla
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Daniel,
thanks a stack for conceiving and maintaining this excellent program. When just using it the first time on the repository cratedb-examples, we discovered a minor flaw that appears when accessing GitHub action workflows that are gone, while the API still enumerates them. This patch addresses that problem.
With kind regards,
Andreas.
Problem Sample
Please visit and review both GHA workflows,
while they are not represented physically within the repository any longer.
Example Output
While the program would previously croak on non-existing workflows, it now runs to completion, while emitting relevant warning messages to the log output.