-
Notifications
You must be signed in to change notification settings - Fork 332
Add Table.exclude method for getting table excluding rows #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… and _rowExcluder
|
In addition to adding a Table.exclude method, this branch makes the following changes:
|
|
Is there an advantage of defining a separate then |
|
If you have a binary mask, you can also do |
|
@SamLau95 Not much of an advantage, but translating |
|
@stefanv That's a cool idea. But seems too space-intensive? (see my previous comment?) |
|
I would like to point out that the space required for constructing indices for the |
|
Cool! Thanks for working on this @mDibyo . |
Add Table.exclude method for getting table excluding rows
|
This PR has now been merged (sorry, I was traveling and couldn't review), but some additional consideration may be worth the time. Is there really no way in which we can combine the logic for take and exclude, without increasing memory usage? Also, we may want to consider using the name Further, I'm curious how API decisions gets made for the |
|
@stefanv The extra memory usage I mentioned is quite small. I could definitely look into ways of combining the two, and welcome your thinking on this too. To me, I think the only conversation we have about the API is on the corresponding issues. For instance, this PR addressed #47. |
|
Also, feel free to review the code now and suggest changes. We can incorporate them in a future PR. |
This fixes #47.