Fix bug in xticks for Table.plot() #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, calling
Table([np.arange(0, 10, .1), np.arange(0, 1, .01)], ['x', 'y']).plot('x')
Would show xticks of 0, 0.1, 0.2, etc. instead of 0, 2, 4, ...
This was beacuse we assumed that the horizontal axis values as passed in
the `ticks` variable were integers. Instead, we should just ask the axis
for the ticks it used to plot the data.
To test:
```python
a = Table([np.arange(0, 10, .1), np.arange(0, 1, .01)], ['x', 'y'])
a.plot('x')
b = Table([np.arange(0, 20, .1), np.arange(0, 2, .01)], ['x', 'y'])
b.plot('x')
SamLau95
added a commit
that referenced
this pull request
Oct 28, 2015
Fix bug in xticks for Table.plot()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, calling
Would show xticks of 0, 0.1, 0.2, etc. instead of 0, 2, 4, ...
This was beacuse we assumed that the horizontal axis values as passed in
the
ticksvariable were integers. Instead, we should just ask the axisfor the ticks it used to plot the data.
To test:
Note that the x labels are still incorrect (the 'y' should be on the vertical axis). I left it as a TODO for now but it'd be good to take care of this.