Add more documentation to hist and barh #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes `Table.hist` throw a more helpful error message when the Table contains invalid values (`np.flexible`, which includes strings). Before, the method raised an error about not being able to operate on "flexible types", which is not extremely helpful without knowledge of numpy types.
SamLau95
changed the title
As well as raising a ValueError with a helpful error message if we try to graph non-numerical values.
SamLau95
force-pushed
the
hist-docstring
branch
2 times, most recently
from
b466839 to
9218d34
Compare
SamLau95
force-pushed
the
hist-docstring
branch
from
9218d34 to
1698fc0
Compare
Contributor
Author
Contributor
|
Yes, that's much improved! |
papajohn
added a commit
that referenced
this pull request
Sep 9, 2015
Add more documentation to hist and barh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes
Table.histandTable.barhthrow a more helpful error message when theTable contains invalid values (
np.flexible, which includes strings).Before, the method raised an error about not being able to operate on
"flexible types", which is not extremely helpful without knowledge of
numpy types.
Starts to address #50.
Travis tests are failing because of a long-standing issue with the date formatter.