[Dev] PandasAnalyzer doesn't actually need pandas
#49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be tested with #50, which disables Pandas for 3.14 builds. |
evertlammerts
approved these changes
Sep 16, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #48
It just sniffs objects to determine if they adhere to a structured type, that doesn't necessarily need pandas
This is kind of untested because all our tests require pandas+numpy
But I went through the logic called by the pandas analyzer and it seems like pandas/numpy are loaded anyways when we first try to compare with a pandas/numpy class type (i.e there's no
import_cache.pandas.NaT(false)in the path)