Skip to content

[Dev] PandasAnalyzer doesn't actually need pandas #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2025
Merged

[Dev] PandasAnalyzer doesn't actually need pandas #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9947be5
pandas is not required to sniff objects
Tishj Sep 15, 2025
f9b3610
Merge branch 'main' into pandas_analyzer_doesnt_need_pandas
evertlammerts Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/duckdb_py/pandas/analyzer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,12 +502,6 @@ bool PandasAnalyzer::Analyze(py::object column) {
if (sample_size == 0) {
return false;
}
auto &import_cache = *DuckDBPyConnection::ImportCache();
auto pandas = import_cache.pandas();
if (!pandas) {
//! Pandas is not installed, no need to analyze
return false;
}

bool can_convert = true;
idx_t increment = GetSampleIncrement(py::len(column));
Expand Down