Skip to content

[DuckDBPyType] Add __hash__ method overload #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 18, 2025
Merged

[DuckDBPyType] Add __hash__ method overload #61

merged 5 commits into from
Sep 18, 2025
+17 −0

Conversation

Tishj
Copy link
Collaborator

@Tishj Tishj commented Sep 17, 2025

This PR fixes #78

@Tishj Tishj changed the base branch from main to v1.4-andium September 17, 2025 08:15
@Tishj
Copy link
Collaborator Author

Tishj commented Sep 17, 2025

I think we stumbled into another windows define..

    python_conversion.cpp
  D:\a\duckdb-python\duckdb-python\src\duckdb_py\include\duckdb_python\pytype.hpp(33,10): error C3646: 'Hash': unknown override specifier [C:\Users\RUNNER~1\AppData\Local\Temp\tmpfoywn8np\build\src\duckdb_py\native\python_native.vcxproj]
    (compiling source file 'D:/a/duckdb-python/duckdb-python/src/duckdb_py/native/python_conversion.cpp')

@evertlammerts evertlammerts added this pull request to the merge queue Sep 18, 2025
Merged via the queue into duckdb:v1.4-andium with commit 134b784 Sep 18, 2025
13 checks passed
@dhirschfeld dhirschfeld mentioned this pull request Sep 18, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evertlammerts evertlammerts evertlammerts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.4.0] TypeError: unhashable type: _duckdb.typing.DuckDBPyType
2 participants
@Tishj @evertlammerts