Skip to content

[DuckDBPyType] Add __hash__ method overload #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 18, 2025
+17 −0
Merged

[DuckDBPyType] Add __hash__ method overload #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9916b99
add hash method
Tishj Sep 17, 2025
0ed02bb
Merge branch 'v1.4-andium' into pytype_hash
evertlammerts Sep 17, 2025
10f0c0e
Merge remote-tracking branch 'upstream/v1.4-andium' into pytype_hash
Tishj Sep 17, 2025
ed6b2c5
avoid collision with windows define
Tishj Sep 17, 2025
f3ab971
third attempt at making windows happy
Tishj Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/duckdb_py/typing/pytype.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,9 @@ void DuckDBPyType::Initialize(py::handle &m) {
py::is_operator());
type_module.def("__eq__", &DuckDBPyType::EqualsString, "Compare two types for equality", py::arg("other"),
py::is_operator());
type_module.def("__hash__", [](const DuckDBPyType &type) {
return py::hash(py::str(type.ToString()));
});
type_module.def_property_readonly("id", &DuckDBPyType::GetId);
type_module.def_property_readonly("children", &DuckDBPyType::Children);
type_module.def(py::init<>([](const string &type_str, shared_ptr<DuckDBPyConnection> connection = nullptr) {
Expand Down
14 changes: 14 additions & 0 deletions tests/fast/test_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,20 @@ def test_struct_from_dict(self):
res = duckdb.list_type({'a': VARCHAR, 'b': VARCHAR})
assert res == 'STRUCT(a VARCHAR, b VARCHAR)[]'

def test_hash_method(self):
type1 = duckdb.list_type({'a': VARCHAR, 'b': VARCHAR})
type2 = duckdb.list_type({'b': VARCHAR, 'a': VARCHAR})
type3 = VARCHAR

type_set = set()
type_set.add(type1)
type_set.add(type2)
type_set.add(type3)

type_set.add(type1)
expected = ['STRUCT(a VARCHAR, b VARCHAR)[]', 'STRUCT(b VARCHAR, a VARCHAR)[]', 'VARCHAR']
assert sorted([str(x) for x in list(type_set)]) == expected

# NOTE: we can support this, but I don't think going through hoops for an outdated version of python is worth it
@pytest.mark.skipif(sys.version_info < (3, 9), reason="python3.7 does not store Optional[..] in a recognized way")
def test_optional(self):
Expand Down