Fix minor typo in duckdb-wasm/README.md #2009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: seiya <20365512+seiyab@users.noreply.github.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundles are defined as
MANUAL_BUNDLESsoselectBundleshould receiveMANUAL_BUNDLESinstead ofJSDELIVR_BUNDLES, I suppose.Adding context, I'm not very sure this fix. I'm not familiar with WASM and Web Workers at all. I'm still struggling setting up duckdb-wasm with Vite 😓.
Just reading the example and guessing with JavaScript knowledge, I consider it won't work and suggest a fix anyway.