Skip to content

Conversation

MasterOdin
Copy link
Contributor

PR bumps the js-sha256 dependency to 0.11.1, which fixes checking for the node environment when running in electron browser.

I also was able to remove some type ignores from the codebase as the issue was fixed in the 0.10.0 release.

Closes #1432

Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
@carlopi
Copy link
Collaborator

carlopi commented May 27, 2025

Thanks!

@carlopi carlopi merged commit 8b31244 into duckdb:main May 27, 2025
15 checks passed
@MasterOdin MasterOdin deleted the chore-deps-js-sha256 branch May 27, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DuckDB-Wasm fails to load in electron with nodeIntegrationInWorker enabled
2 participants