support PIVOT with send #2047
Merged
support PIVOT with send #2047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlopi Finally got the tests to pass. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIVOT is transformed into multiple statements by the parser. Since PendingQuery doesn't support multiple statements, this causes PIVOT statements to fail when used with
send.This change fixes this by using ExtractStatements to transform the text passed to WebDB::Connection::PendingQuery into possibly multiple parsed statements. Each one is run in turn; results are returned for the last one.
I added a unit test for this case. I did have to skip some of the checks (of the aggregated values) on Node, because they were returned as different types depending on the build (loadable or not). They work fine in the browser.