Skip to content

v1.3.4

  • v1.3.4
  • c42a78e
  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
  • Choose a tag to compare

  • v1.3.4
  • c42a78e
  • Choose a tag to compare

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Mtrya Mtrya tagged this 14 Apr 22:36
# Pull Request

## Description

This change updates the texture lookup in `brahe.plots.texture_utils` to
load the asset via `importlib.resources`, adds the packaged data module
and image to the distribution configuration, and adds a test that checks
the resource is present as an installed package asset.

## Changelog
- Package the Blue Marble texture in Python distributions so
`get_blue_marble_texture_path()` works from installed wheels
- Load the bundled texture via `importlib.resources`

## Changed
- Add `brahe.plots.data` as the home for packaged plotting resources
- Add a test covering Blue Marble resource packaging

## Related Issue

#268 

## Note to Reviewers

The Blue Marble resource seems to be a quite unusual case that sits in
the middle:
- it's not protected by Rust's embedding pattern, so it's not in
`brahe/_brahe.so` (and it shouldn't)
- it's meant to be a built-in asset, not user-supplied or cache-download

It's probably the only instance of this specific failure mode, but I
didn't check too closely.

Co-authored-by: Duncan Eddy <6956476+duncaneddy@users.noreply.github.com>
Assets 2
Loading