imgup Fly.io App deployment overwriting AWS env vars leading to failure

[nelsonic]

At present the automatic continuous deployment (CD) from GitHub actions to Fly.io for the imgup app works partially.

https://imgup.fly.dev/liveview

imgup-liveview-upload-working.mov

However the REST API fails when we attempt to upload in Hoppscotch:

The app was recently deployed: https://fly.io/apps/imgup

In the logs following the failed API request we see the following error:
https://fly.io/apps/imgup/monitoring

[error] ** (MatchError) no match of right hand side value: {:error, "Required key: :secret_access_key is nil in config!"}

Which relates to the following line of code:

imgup/lib/app_web/controllers/api_controller.ex

Line 13 in 62fc7f9

Logger.error(Exception.format(:error, e, __STACKTRACE__))

Not super informative, but we know the upload is failing due to unavailability of the AWS :secret_access_key ... 🙃

So we know what needs to be fixed ... 🤞

Todo

• Remove the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY from ci.yml:
  

  imgup/.github/workflows/ci.yml

  Lines 61 to 62 in 7eb43e7

  	AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
  	AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

• Update the FLY_API_TOKEN to the dwyl account.
• Create PR updating.

[nelsonic]

Creating a new fly.yml file as per: https://fly.io/docs/app-guides/continuous-deployment-with-github-actions/

[nelsonic]

https://github.com/dwyl/imgup/settings/secrets/actions

[nelsonic]

PR #79 🙏

[nelsonic]

Confirmed the deploy works and API works:

{
  "compressed_url": "https://s3.eu-west-3.amazonaws.com/imgup-compressed/zb2rhmV9nb6eHoRmdiqxtn54LmybbkBTGZ9gwBVaW8KjPGQJ2.jpg",
  "url": "https://s3.eu-west-3.amazonaws.com/imgup-original/zb2rhmV9nb6eHoRmdiqxtn54LmybbkBTGZ9gwBVaW8KjPGQJ2.jpg"
}

Original:

Compressed: