Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Resolve API Deployment issue #78 #79

Merged
merged 3 commits into from
Jun 21, 2023
Merged

PR: Resolve API Deployment issue #78 #79

merged 3 commits into from
Jun 21, 2023

Conversation

nelsonic
Copy link
Member

This PR should fix the API issue described in #78 🤞

@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt technical A technical issue that requires understanding of the code, infrastructure or dependencies tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. BLOCKED :fire: Core team's HIGHEST priority, blocking critical work labels Jun 21, 2023
@nelsonic
Copy link
Member Author

@LuchoTurtle as discussed on our call, this should fix the API deployment issue we were seeing during the demo. 🤞

LuchoTurtle
LuchoTurtle approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@LuchoTurtle LuchoTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nelsonic nelsonic mentioned this pull request Jun 21, 2023
Closed
3 tasks
@LuchoTurtle LuchoTurtle merged commit a91935a into main Jun 21, 2023
@LuchoTurtle LuchoTurtle deleted the resolve-api-deployment-issue-#78 branch June 21, 2023 09:07
@nelsonic
Copy link
Member Author

This is dependent on the changes made in #70

@LuchoTurtle
Copy link
Member

See #81. The deploy.yml file was placed in the wrong folder, therefore not running when merges occur to the main branch.

@LuchoTurtle LuchoTurtle mentioned this pull request Jun 21, 2023
Merged
@LuchoTurtle
Copy link
Member

Just tested with Hoppscotch and I've confirmed it's working 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuchoTurtle LuchoTurtle LuchoTurtle approved these changes

Assignees

@LuchoTurtle LuchoTurtle

Labels
awaiting-review An issue or pull request that needs to be reviewed BLOCKED :fire: Core team's HIGHEST priority, blocking critical work chore a tedious but necessary task often paying technical debt T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @LuchoTurtle