Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows! #4

Open
nelsonic opened this issue Jan 28, 2016 · 8 comments
Open

Windows! #4

nelsonic opened this issue Jan 28, 2016 · 8 comments

Comments

@nelsonic
Copy link
Member

We need to test our pre-commit hooks with windows... 💻
@jrans please keep us posted with your progress on this quest! 👍

@ryanpcmcquen
Copy link

Peeps still uses windows?!?

@jrans
Copy link
Member

jrans commented Jan 29, 2016

@nelsonic This is how I spent last night! Can you review?

@nelsonic
Copy link
Member Author

@jrans looks great.
Would you mind PR-ing a section into this readme pointing people to your readme when they have "Advanced" needs? 😉

@nelsonic
Copy link
Member Author

@ryanpcmcquen sadly, Windows is not going away any time soon... Most "Big" companies still use windows (because they don't know any better...) so we have to consider it...

@ryanpcmcquen
Copy link

Haha, I know. I am always surprised when I meet devs who use it, but it takes all kinds, right?

:-P

@nelsonic
Copy link
Member Author

Yeah, even IBM have realised that Mac has lower Total Cost of Ownership: http://www.computerworld.com/article/2998315/apple-mac/every-mac-we-buy-is-making-and-saving-ibm-money-ibm.html

Its a case of:

old habits die hard

jrans added a commit that referenced this issue Feb 1, 2016
 + Address issue #4 and problems you may face with pre-commit.
 + Write advanced section on how to write your own.
 + Update other languages section to suggest writing you own.
@jrans
Copy link
Member

jrans commented Feb 1, 2016

I think the problem is pre-commit uses fs.symlink to copy git hook into .git folder but you may need admin rights to this in Windows. Have made a PR to README to suggest how you can write your own copy them over. This may also help with all other languages as can just use them to write the scripts!

@nelsonic
Copy link
Member Author

nelsonic commented Feb 2, 2016

@jrans this Commit message on the pre-commit module says it all:
observing/pre-commit@d570d16

Thanks for adding the advanced section. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants