address comments

Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
dydxprotocol · Mar 6, 2024 · 78ebcda · 78ebcda
1 parent 4a7d3a9
commit 78ebcda
Show file tree

Hide file tree

Showing 3 changed files with 88 additions and 45 deletions.
diff --git a/protocol/x/subaccounts/keeper/subaccount.go b/protocol/x/subaccounts/keeper/subaccount.go
@@ -72,7 +72,7 @@ func (k Keeper) GetCollateralPoolForSubaccount(ctx sdk.Context, subaccountId typ
 }
 
 // GetCollateralPoolForSubaccountWithPerpetuals returns the collateral pool address based on the
-// perpetual passes in as an argument.
+// perpetual passed in as an argument.
 func (k Keeper) GetCollateralPoolFromPerpetualId(ctx sdk.Context, perpetualId uint32) (sdk.AccAddress, error) {
 	perpetual, err := k.perpetualsKeeper.GetPerpetual(ctx, perpetualId)
 	if err != nil {

diff --git a/protocol/x/subaccounts/keeper/transfer.go b/protocol/x/subaccounts/keeper/transfer.go
@@ -242,18 +242,18 @@ func (k Keeper) TransferFeesToFeeCollectorModule(
 	}
 
 	// Send coins from `subaccounts` to the `auth` module fee collector account.
-	fromModule := collateralPoolAddr
-	toModule := authtypes.NewModuleAddress(authtypes.FeeCollectorName)
+	fromModuleAddr := collateralPoolAddr
+	toModuleAddr := authtypes.NewModuleAddress(authtypes.FeeCollectorName)
 
 	if quantums.Sign() < 0 {
 		// In the case of a liquidation, net fees can be negative if the maker gets a rebate.
-		fromModule, toModule = toModule, fromModule
+		fromModuleAddr, toModuleAddr = toModuleAddr, fromModuleAddr
 	}
 
 	if err := k.bankKeeper.SendCoins(
 		ctx,
-		fromModule,
-		toModule,
+		fromModuleAddr,
+		toModuleAddr,
 		[]sdk.Coin{coinToTransfer},
 	); err != nil {
 		return err