This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Added support for SkiffOS #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paralin
force-pushed
the
add-distro-skiffos
branch
6 times, most recently
from
a9fd31d
to
816dd81
Compare
|
|
paralin
added a commit
to paralin/neofetch
that referenced
this pull request
Jan 22, 2021
https://github.com/skiffos/skiffos Fixes dylanaraps#1664 Signed-off-by: Christian Stewart <christian@paral.in>
paralin
force-pushed
the
add-distro-skiffos
branch
2 times, most recently
from
19a168d
to
124c015
Compare
paralin
force-pushed
the
add-distro-skiffos
branch
5 times, most recently
from
2309b69
to
d1c528a
Compare
|
|
|
LGTM! |
dylanaraps
reviewed
Jun 11, 2021
neofetch
Outdated
Comment on lines
996
to
1001
| elif [[ -f /etc/skiffos-release ]]; then | ||
| case $distro_shorthand in | ||
| on|tiny) distro=SkiffOS ;; | ||
| *) distro="SkiffOS ($(cat /etc/skiff-release | grep PRETTY_NAME | awk -F'"' '$0=$2'))" | ||
| esac | ||
|
|
There was a problem hiding this comment.
Existing detection methods don't work?
There was a problem hiding this comment.
/etc/os-release:
NAME=SkiffOS
VERSION=2021.02.2-31-g9badfd5
ID=skiff
VERSION_ID=9badfd5
PRETTY_NAME="SkiffOS 2021.02.2-31-g9badfd5"
BUILD_DATE="Thu Jun 10 17:11:44 PDT 2021"
BUILD_USER="paralin@forge"
VERSION_FULL="SkiffOS version 2021.02.2-31-g9badfd5 (paralin@forge) Thu Jun 10 17:11:44 PDT 2021"
/etc/skiff-release
NAME=SkiffOS
VERSION=2021.02.2-31-g9badfd5
ID=skiff
VERSION_ID=9badfd5
PRETTY_NAME="SkiffOS 2021.02.2-31-g9badfd5"
BUILD_DATE="Thu Jun 10 17:11:44 PDT 2021"
BUILD_USER="paralin@forge"
VERSION_FULL="SkiffOS version 2021.02.2-31-g9badfd5 (paralin@forge) Thu Jun 10 17:11:44 PDT 2021"
BUILD_CONFIG="pine64/common,skiff/moduleimg,pine64/phone,apps/docker,skiff/core,core/gentoo"
There was a problem hiding this comment.
The current master fails on my end, I bisected it to commit 41f75b7b484cca653e0db19b194d99a993dbf5f8
neofetch: line 6364: syntax error near unexpected token )' neofetch: line 6364: "CelOS"*)'
There was a problem hiding this comment.
OK @dylanaraps I simplified it to use existing os-release detection, works fine.
paralin
force-pushed
the
add-distro-skiffos
branch
from
d1c528a
to
cb68356
Compare
Signed-off-by: Christian Stewart <christian@paral.in>
https://github.com/skiffos/skiffos Fixes dylanaraps#1657 Signed-off-by: Christian Stewart <christian@paral.in>
paralin
force-pushed
the
add-distro-skiffos
branch
from
cb68356
to
ef02b23
Compare
|
Thanks again. |
matt-fidd
pushed a commit
to matt-fidd/neofetch
that referenced
this pull request
Sep 12, 2022
* os: fix syntax error introduced by celos logo Signed-off-by: Christian Stewart <christian@paral.in> * Added support for SkiffOS https://github.com/skiffos/skiffos Fixes dylanaraps#1657 Signed-off-by: Christian Stewart <christian@paral.in>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/skiffos/skiffos
Fixes #1657