Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[generator] Support shell commands like go generate #53

Closed
1 of 2 tasks
at15 opened this issue Feb 21, 2018 · 0 comments
Closed
1 of 2 tasks

[generator] Support shell commands like go generate #53

at15 opened this issue Feb 21, 2018 · 0 comments
Labels
pkg/generator type/new-feature

Comments

@at15
Copy link
Member

at15 commented Feb 21, 2018 •
edited
Loading

  • need to use it for protobuf
    • might need the env feature in config package
  • clean up generator code
  • clean up config package, no longer need searchMap like viper
at15 added a commit that referenced this issue Feb 21, 2018
@at15
[generator] Init shell generator #53
09e2ecd 
- use `sh -c` if `shell` flag is set
- use `shellquote` package to split fields instead of simply
strings.Fields, which does not met user's expectation most times
  - saw it in github's hub https://github.com/github/hub
- use `cd` flag to specify if switching to folder of `gommon.yml` file
is required
- sync execution, no parallel, pipe to stdin/out/err
at15 added a commit to benchhub/benchhub that referenced this issue Feb 21, 2018
@at15
[c][a] Use gommon to call protoc for code gen
4df896d 
- dyweb/gommon#53
@at15 at15 closed this as completed in 42b6cd7 Feb 21, 2018
at15 added a commit that referenced this issue Feb 21, 2018
@at15
[deprecate][runner] Move runner to legacy
cfbaebe 
- it only provides a very thin wrapper around `os/exec`, too thin that
we didn't use it when execute shell commands in generator #53
- the only user should be Ayi, which is likely to be rewrote from
scratch when I have time (I'd rather play games ...)
- update legacy packages in readme, log v1 is also included
@at15 at15 mentioned this issue Feb 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg/generator type/new-feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@at15