Skip to content
This repository was archived by the owner on May 30, 2025. It is now read-only.

fix(EbayListboxButton): Show listbox with active descendent on button focus #382

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(EbayListboxButton): Show listbox with active descendent on button focus #382

merged 1 commit into from
Dec 20, 2024

Conversation

HenriqueLimas
Copy link
Member

  • Show the listbox on focus of the button since on click the screen reader cannot check for it on focus
  • Update aria-activedescendent logic to render function instead of manually setting the attributes of the ref
  • Move aria-activedescendent to listbox component instead of div container

@HenriqueLimas HenriqueLimas self-assigned this Dec 20, 2024
shpandian
shpandian approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@shpandian shpandian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shpandian shpandian merged commit 0480411 into main Dec 20, 2024
6 checks passed
@shpandian shpandian deleted the fix-listbox-button-focus branch December 20, 2024 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkwebdev darkwebdev Awaiting requested review from darkwebdev

1 more reviewer

@shpandian shpandian shpandian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@HenriqueLimas HenriqueLimas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenriqueLimas @shpandian