Include messages while testing signaling conditions #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #335 +/- ##
==========================================
- Coverage 60.05% 60.03% -0.02%
==========================================
Files 46 46
Lines 3154 3155 +1
==========================================
Hits 1894 1894
- Misses 1260 1261 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
3 tasks
IndrajeetPatil
approved these changes
Feb 4, 2023
There was a problem hiding this comment.
Thanks, @rempsyc!
Yes, all these changes look good to me. And it's good that you have also updated the CRAN comments. Once submitted, @DominiqueMakowski should get an email. Hopefully, he responds quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses easystats/easystats#272 (include messages while testing signaling conditions), closes #322 (update authorship).
@IndrajeetPatil, I believe that was the last maintainer assignement for
report. Any other assignment I missed before I submit to CRAN?