Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename group/group_by arguments into by #433

Merged
merged 15 commits into from
May 24, 2024
Merged

Rename group/group_by arguments into by #433

merged 15 commits into from
May 24, 2024

Conversation

strengejacke
Copy link
Member

@@ -88,7 +88,7 @@
.report_model_ttest <- function(x, table) {
# If against mu
if (names(x$null.value) == "mean") {
# TODO: @DominiqueMakowski why do we need "table" here?
# TODO: @DominiqueMakowski why do we need "table" here??

Copy link
Member Author

@strengejacke strengejacke May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DominiqueMakowski ?
The object table is never used...

@strengejacke strengejacke merged commit bf636ee into main May 24, 2024
19 of 29 checks passed
@strengejacke strengejacke deleted the rename_group_by branch May 24, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant