Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin dependencies corresponding to latest sprotty release #104

Closed
tortmayr opened this issue Aug 19, 2020 · 1 comment
Closed

Pin dependencies corresponding to latest sprotty release #104

tortmayr opened this issue Aug 19, 2020 · 1 comment
Assignees
@tortmayr

Comments

@tortmayr
Copy link
Contributor

Sprotty has relased version 0.9.0. Since we are planning to do the first GLSP release soon we should pin all our dependencies to sprotty/sprotty-theia to the release version. In addition, we should align the theia versions ("^1.0.0").

After the release is done we can swap back to using next dependencies
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Aug 24, 2020
@tortmayr
#94 #104 Clean up communication protocol
98532b0 
- Clean up communication and move implementation into glsp client
- Define a "clean" `GLSPClient` interface that is independent from the underlying communication protocol
- Provide a base implementation for a jsonrpc-based `GLSPClient`
- Update dependencies to sprotty 0.9.0
- Align dependency versions with Theia versions
- Add new DisposeClientAction to notify the server if a specific diagram client/widget can be disposed (e.g. on editor tab close)

Part of:
- eclipse-glsp/glsp/issues/104
- eclipse-glsp/glsp/issues/94
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Aug 24, 2020
@tortmayr
#96 #94 Cleanup and refactor client-server communication
6eaf36c 
- Refactor client-server communication into a base protocol and a jsonrpc specific implementation (#94)
- Cleanup protocol and implement (previously unused) shutdown method
- Add ClientSessionManager to track lifecycle of GLSP client connections (#96)
- Add listener-mechanism to react to lifecycle changes (used in 
DefaultModelStateProvider)
- Remove (now obsolete) GLSPClientProxyProvider
- Fix wrong version of guava in org.eclipse.glsp.graph pom.xml
- Add unique applicationId to InitializeParameters

Part of:
- eclipse-glsp/glsp/issues/104
- eclipse-glsp/glsp/issues/94
- eclipse-glsp/glsp/issues/96
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Aug 24, 2020
@tortmayr
#94 #104 #96 Clean up communication protocol
57e9e45 
- Clean up communication and move implementation into glsp client
- Define a "clean" `GLSPClient` interface that is independent from the underlying communication protocol
- Provide a base implementation for a jsonrpc-based `GLSPClient`
- Update dependencies to sprotty 0.9.0
- Align dependency versions with Theia versions
- Add new DisposeClientAction to notify the server if a specific diagram client/widget can be disposed (e.g. on editor tab close)

Part of:
- eclipse-glsp/glsp/issues/104
- eclipse-glsp/glsp/issues/94
- eclipse-glsp/glsp/issues/96
@tortmayr tortmayr mentioned this issue Aug 24, 2020
Merged
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Aug 24, 2020
@tortmayr
#105 #104 #96 #94 #39 Cleanup and refactor glue code
34dbaab 
- Remove deprecated glsp client protcol and reuse the new API provided by @eclipse-glsp/client (#94 #96)
- Update dependencies to align with sprotty 0.9.0 and Theia 1.3.0. (104)
- Refactor glsp contributions to avoid dependencies on the (now deprecated) @theia/language module (#105)
- Provide a dedicated TheiaGLSPClient that uses the MessageService to propagate connection errors. (#39)
- Use unique application id in widgetId.

Requires: eclipse-glsp/glsp-client/pull/79

Part of:
- eclipse-glsp/glsp/issues/104
- eclipse-glsp/glsp/issues/94
- eclipse-glsp/glsp/issues/96
- eclipse-glsp/glsp/issues/105
- eclipse-glsp/glsp/issues/39
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Aug 24, 2020
@tortmayr
#105 #104 #96 #94 #39 Cleanup and refactor client-server communication
6fa15d9 
- Remove deprecated glsp client protcol and reuse the new API provided by @eclipse-glsp/client (#94 #96)
- Update dependencies to align with sprotty 0.9.0 and Theia 1.3.0. (104)
- Refactor glsp contributions to avoid dependencies on the (now deprecated) @theia/language module (#105)
- Provide a dedicated TheiaGLSPClient that uses the MessageService to propagate connection errors. (#39)
- Use unique application id in widgetId.

Requires: eclipse-glsp/glsp-client/pull/79

Part of:
- eclipse-glsp/glsp/issues/104
- eclipse-glsp/glsp/issues/94
- eclipse-glsp/glsp/issues/96
- eclipse-glsp/glsp/issues/105
- eclipse-glsp/glsp/issues/39
@tortmayr tortmayr mentioned this issue Aug 24, 2020
Merged
tortmayr added a commit to eclipse-glsp/glsp-examples that referenced this issue Aug 24, 2020
@tortmayr
#105 #104 #96 #94 #39 Refactor client-server communication
47aea72 
-Update dependencies to conform to sprotty 0.9.0 and Theia 1.3.0
- Adapt code to confrom to client/server changes
- Change argument for passing the server port to "WF_GLSP"

Requires: 
- eclipse-glsp/glsp-server/pull/73
- eclipse-glsp/glsp-theia-integration/pull/44

Part of:
- eclipse-glsp/glsp/issues/104
- eclipse-glsp/glsp/issues/94
- eclipse-glsp/glsp/issues/96
- eclipse-glsp/glsp/issues/105
@tortmayr tortmayr mentioned this issue Aug 24, 2020
Merged
@tortmayr
Copy link
Contributor Author

The attached PRS resolve this issue. Dependency versions are aligned with sprotty 0.9.0 and Theia 1.3.0. We cannot use later versions of Theia yet, because we are still depending on @theia/languages (now deprecated)

tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Aug 25, 2020
@tortmayr @planger
#94 #104 #96 Clean up communication protocol (#79)
f55a32f 
* #94 #104 #96  Clean up communication protocol 

- Clean up communication and move implementation into glsp client
- Define a "clean" `GLSPClient` interface that is independent from the underlying communication protocol
- Provide a base implementation for a jsonrpc-based `GLSPClient`
- Update dependencies to sprotty 0.9.0
- Align dependency versions with Theia versions
- Add new DisposeClientAction to notify the server if a specific diagram client/widget can be disposed (e.g. on editor tab close)

Part of:
- eclipse-glsp/glsp/issues/104
- eclipse-glsp/glsp/issues/94
- eclipse-glsp/glsp/issues/96

* Fix minors

* Adapt copyright headers

Co-authored-by: Philip Langer <planger@eclipsesource.com>
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Aug 25, 2020
@tortmayr @planger
#105 #104 #96 #94 #39 Cleanup and refactor client-server communication (
7f0fe83 
#44)

* #105 #104 #96 #94 #39 Cleanup and refactor client-server communication

- Remove deprecated glsp client protcol and reuse the new API provided by @eclipse-glsp/client (#94 #96)
- Update dependencies to align with sprotty 0.9.0 and Theia 1.3.0. (104)
- Refactor glsp contributions to avoid dependencies on the (now deprecated) @theia/language module (#105)
- Provide a dedicated TheiaGLSPClient that uses the MessageService to propagate connection errors. (#39)
- Use unique application id in widgetId.

Requires: eclipse-glsp/glsp-client/pull/79

Part of:
- eclipse-glsp/glsp/issues/104
- eclipse-glsp/glsp/issues/94
- eclipse-glsp/glsp/issues/96
- eclipse-glsp/glsp/issues/105
- eclipse-glsp/glsp/issues/39

* Fix minors and remove dep to @theia/languages

Co-authored-by: Philip Langer <planger@eclipsesource.com>
@tortmayr tortmayr self-assigned this Aug 25, 2020
tortmayr added a commit to eclipse-glsp/glsp-examples that referenced this issue Aug 25, 2020
@tortmayr @planger
#105 #104 #96 #94 #39 Refactor client-server communication (#63)
51b45d4 
* #105 #104 #96 #94 #39 Refactor client-server communication

-Update dependencies to conform to sprotty 0.9.0 and Theia 1.3.0
- Adapt code to confrom to client/server changes
- Change argument for passing the server port to "WF_GLSP"

Requires: 
- eclipse-glsp/glsp-server/pull/73
- eclipse-glsp/glsp-theia-integration/pull/44

Part of:
- eclipse-glsp/glsp/issues/104
- eclipse-glsp/glsp/issues/94
- eclipse-glsp/glsp/issues/96
- eclipse-glsp/glsp/issues/105

* Update launch config to changed env args

* Adapt copyright headers

* Update versions

Co-authored-by: Philip Langer <planger@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tortmayr