Skip to content

Rewrite test based on enzyme #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2019
Merged

Rewrite test based on enzyme #1262

merged 1 commit into from
Feb 18, 2019

Conversation

edgarmueller
Copy link
Contributor

No description provided.

@edgarmueller edgarmueller added this to the 2.3.0 milestone Feb 15, 2019
@edgarmueller edgarmueller changed the title [material] Rewrite test based on enzyme Rewrite test based on enzyme Feb 15, 2019
@coveralls
Copy link

coveralls commented Feb 16, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 88.266% when pulling db924db on edgarmueller:feat/material-enzyme into 374b6d5 on eclipsesource:master.

eneufeld
eneufeld requested changes Feb 17, 2019
View reviewed changes
Copy link
Member

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the refactoring.
I would suggest to update all headers of classes we touch.
I also found 2 classes which are simply commented out, what is the reason for that?

@edgarmueller
Copy link
Contributor Author

Thanks for the review. It got a bit late and forgot to un-comment those tests. Those should be fine now.

eneufeld
eneufeld approved these changes Feb 18, 2019
View reviewed changes
Copy link
Member

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small improvement suggestion

@edgarmueller edgarmueller merged commit 4eb1005 into eclipsesource:master Feb 18, 2019
@edgarmueller edgarmueller modified the milestones: 2.3.0, 2.2.1 Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eneufeld eneufeld eneufeld approved these changes

Assignees
No one assigned
Labels
dev material
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@edgarmueller @coveralls @eneufeld