Introduce new 'show' option for control labels #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new configuration option in ui schemas for labels of
controls. In particular a 'show' option is added which allows to hide labels.
Instead of simply a string, a label for a control can now be defined as string,
boolean or {text:string, show:boolean} object. If not specified, 'true' for
show and the 'beautified schemapath' for text are assumed.
Includes testcases.
|
|
||
| it("should hide the label when text is defined but show is set to false", inject(($rootScope, $compile) => { | ||
| let scope = $rootScope.$new(); | ||
| scope.schema = { |
There was a problem hiding this comment.
The schema seems to be the same in all cases, maybe we could extract it and declare it as a global var within the test
|
This looks good! The one comment I added I'll probably take care of myself. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183
Introduces a new configuration option in ui schemas for labels of
controls. In particular a 'show' option is added which allows to hide labels.
Labels are now configured as blocks with a min-height of 20px (the current line-height) to avoid misalignments between inputs with and without labels. However when no label for any control is displayed there are seamingly meaningless 20px of whitespace present. This problem should probably be solved in a generic way in a future PR since labels are also used to display the required property.