Improve angular performance #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase rendering and on change performance for all forms including nultiple layouts: * Avoid unnecessary recalculation of the child render props. * In turn, avoid some unnecessary change detection cycles in children.
When querying the state from the `JsonFormsAngularService` via its `getState` method, the whole state is cloned. This lead to a heavy performance penalty because the `JsonFormsAbstractControl` queried the state on every change detection cycle to get the global config. Thus, the whole state was cloned for every control on every change. As the config is only a small part of the state, this problem can be alleviated by adding a getConfig method to the service that only clones the config. * Extend `JsonFormsAngularService` with a `getConfig` method that returns a clone of the global config * Use the new method in `JsonFormsAbstractControl` Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
When querying the state from the `JsonFormsAngularService` via its `getState` method, the whole state is cloned. This could lead to performance issues with the angular material renderer set because the `NumberControlRenderer` queried the state on every change detection cycle to get the locale. Thus, the whole state was cloned for every control of these types on every change. To fix this, the `JsonFormsAngularService` now allows to query the locale directly without cloning the state * Add method `getLocale` to `JsonFormsAngularService` that does not clone the state * Use new method in `NumberControlRenderer` Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
|
Please can we get this reviewed by an approver? The angular component at the moment is very slow and laggy when we have more than a dozen components. |
|
Hi @FredUK, yes will review soonish and if there are no issues this will be part of the next (pre)release. |
sdirix
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate Angular layout renderer child props via a pure pipe
Increase rendering and on change performance for all forms including nultiple layouts:
Add service method to get global config
When querying the state from the
JsonFormsAngularServicevia itsgetStatemethod, the whole state is cloned.This lead to a heavy performance penalty because the
JsonFormsAbstractControlqueried the state on every change detection cycle to get the global config. Thus, the whole state was cloned for every control on every change.As the config is only a small part of the state, this problem can be alleviated by adding a getConfig method to the service that only clones the config.
JsonFormsAngularServicewith agetConfigmethod that returns a clone of the global configJsonFormsAbstractControlAdd service method to get locale
When querying the state from the
JsonFormsAngularServicevia itsgetStatemethod, the whole state is cloned.This could lead to performance issues with the angular material renderer set because the
NumberControlRendererqueried the state on every change detection cycle to get the locale. Thus, the whole state was cloned for every control of these types on every change.To fix this, the
JsonFormsAngularServicenow allows to query the locale directly without cloning the stategetLocaletoJsonFormsAngularServicethat does not clone the stateNumberControlRendererFix #1946