reset data in anyOfRenderer, if data types dont match #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lucas-koehler
requested changes
Sep 11, 2023
There was a problem hiding this comment.
Hi @LukasBoll
Thanks for the pull request ❤️
I have some comments inline. Please have a look.
packages/material-renderers/src/complex/MaterialAnyOfRenderer.tsx
Outdated
Show resolved
Hide resolved
LukasBoll
force-pushed
the
fix-switch-any-of-renderer
branch
from
74f67e0
to
97b52ea
Compare
|
Thank you very much for the review and your comments! I adressed all of your comments! |
lucas-koehler
requested changes
Sep 20, 2023
There was a problem hiding this comment.
Hi @LukasBoll , thanks for the updates. I found one small bug inline and added a suggestion to fix it.
packages/material-renderers/src/complex/TabSwitchConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
lucas-koehler
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
@LukasBoll I merged the minor suggested fix. Thanks again for the contribution :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2173