Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement GitHub Action for Publishing #2223

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

LukasBoll
Copy link
Contributor

Introduce a GitHub Action to automate the publishing process for JSON Forms.
adjust dependencies with lerna
adjust peerdependencies with custom script

closes #2047

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 1447886
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/657b00d12d541a00081c7db7
😎 Deploy Preview https://deploy-preview-2223--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Dec 4, 2023

Coverage Status

coverage: 83.078% (+0.05%) from 83.033%
when pulling 1447886 on LukasBoll:publish_github_action
into 18c0825 on eclipsesource:master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some comments

.github/workflows/publish.yaml Outdated Show resolved Hide resolved
.github/workflows/publish.yaml Outdated Show resolved Hide resolved
.github/workflows/publish.yaml Outdated Show resolved Hide resolved
.github/workflows/publish.yaml Outdated Show resolved Hide resolved
Introduce a GitHub Action to automate the publishing process for
JSON Forms.
adjust dependencies with lerna
adjust peerdependencies with custom script
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add build and test steps, please check preparePublish script

@sdirix sdirix marked this pull request as ready for review December 14, 2023 13:09
@sdirix sdirix merged commit 1b517d6 into eclipsesource:master Dec 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GH action for publish
3 participants