Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor MrkvNow into model state variable in ConsAggShockModel #933

Closed
sbenthall opened this issue Jan 27, 2021 · 1 comment · Fixed by #935
Closed

refactor MrkvNow into model state variable in ConsAggShockModel #933

sbenthall opened this issue Jan 27, 2021 · 1 comment · Fixed by #935
Milestone
0.11.0

Comments

@sbenthall
Copy link
Contributor

In ConsAggShockModel, the model variable MrkvNow is currently stored as an object attribute.

Is it a state? A shock?

Either way, it should be changed into a namespaced variable for consistency with the new style.
@sbenthall sbenthall added this to the 1.0.0 milestone Jan 27, 2021
@sbenthall sbenthall mentioned this issue Jan 27, 2021
Closed
@sbenthall
Copy link
Contributor Author

Ah. So one reason this has not been refactored before is that it looks like the MrkvNow property in ConsAggShockModel is an aggregate level variable.

See the discussion here:
#761 (comment)

It also looks like this is handled slightly differentling in the ConsMarkovAggShockModel and the KrusselSmithModel

sbenthall added a commit to sbenthall/HARK that referenced this issue Jan 28, 2021
@sbenthall
replace MrkvNow in KrusellSmith with shocks['Mrkv'], see econ-ark#933
11a37dd
sbenthall added a commit to sbenthall/HARK that referenced this issue Jan 28, 2021
@sbenthall
MrkvNow --> shocks['Mrkv'] for AggShockMarkovConsumerType, see econ-a…
a068263 
…rk#933
@sbenthall sbenthall mentioned this issue Jan 28, 2021
Merged
3 tasks
sbenthall added a commit to sbenthall/HARK that referenced this issue Feb 7, 2021
@sbenthall
CHANGELOG for moving MrkvNow to shocks['Mrkv'], fixes econ-ark#933
e7d637d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

MrkvNow into model state shocks['Mrkv'] in AggShockMarkov and KrusellSmith models sbenthall/HARK
1 participant
@sbenthall